copy-from-rbenv now checks that rbenv dirs exist and aren't empty#161
Open
ravenhall wants to merge 1 commit intotokuhirom:masterfrom
Open
copy-from-rbenv now checks that rbenv dirs exist and aren't empty#161ravenhall wants to merge 1 commit intotokuhirom:masterfrom
ravenhall wants to merge 1 commit intotokuhirom:masterfrom
Conversation
|
This is good to go can we get this merged in @tokuhirom ? |
syohex
reviewed
Mar 18, 2020
| libexec/plenv-which | ||
| cp ~/.rbenv/libexec/* libexec/ | ||
| cp ~/.rbenv/completions/* completions/ | ||
| if [[ "$(ls -A ~/.rbenv)" && "$(ls -A ~/.rbenv/libexec)" && "$(ls -A ~/.rbenv/completions)" ]]; |
Collaborator
There was a problem hiding this comment.
Is it enough to use -d file test operator instead of ls -A ? ls -A some_path shows error if some_path does not exist like ls: /Users/shohei.yoshida/.rbenv: No such file or directory.
Author
There was a problem hiding this comment.
I am fine with using -d if that's preferred.
| perl -i -pe 's/version="[0-9.]+"/version="$ENV{GIT_REVISION}"/' libexec/plenv---version | ||
| perl -i -pe 's!print_summaries commands local global shell install uninstall rehash version versions which whence!print_summaries commands local global shell install uninstall rehash version versions which whence list-modules migrate-modules install-cpanm!; s!%-9s!%-17s!' libexec/plenv-help | ||
| else | ||
| echo "rbenv not detected for this user, no changes were made." |
Collaborator
There was a problem hiding this comment.
Indentation of else block is different from then block. IMO Indent size should be 2 space because other scripts uses it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at open issues, I happened to run 'make' on my (working, up to date) plenv installation. The script author/copy-from-rbenv.sh trashed my plenv install. This patch checks that ~/.rbenv, ~/.rbenv/completions, and ~/.rbenv/libexec exist and are not empty before whacking the corresponding plenv directories.
Git status revealed the damage:
deleted: completions/plenv.bash
deleted: completions/plenv.fish
deleted: completions/plenv.zsh
deleted: libexec/plenv
deleted: libexec/plenv---version
deleted: libexec/plenv-commands
deleted: libexec/plenv-completions
deleted: libexec/plenv-exec
deleted: libexec/plenv-global
deleted: libexec/plenv-help
deleted: libexec/plenv-hooks
deleted: libexec/plenv-init
deleted: libexec/plenv-local
deleted: libexec/plenv-prefix
deleted: libexec/plenv-rehash
deleted: libexec/plenv-root
deleted: libexec/plenv-sh-rehash
deleted: libexec/plenv-sh-shell
deleted: libexec/plenv-shims
deleted: libexec/plenv-version
deleted: libexec/plenv-version-file
deleted: libexec/plenv-version-file-read
deleted: libexec/plenv-version-file-write
deleted: libexec/plenv-version-name
deleted: libexec/plenv-version-origin
deleted: libexec/plenv-versions
deleted: libexec/plenv-whence
deleted: libexec/plenv-which